✨ Test and fix #1315 #1369
Merged
✨ Test and fix #1315 #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
— 🛠 Update SOL_IS_(DEFAULT_)ON/OFF usage to be more idiomatic and less confusing (add SOL_RAW_* alternatives as well) — 💚 Re-check CI — 👷♀️ Add missing header from ebco.hpp
— Lua 5.1, 5.2, and 5.3 seemed to have a deficiency in which the stack thread space variable (given as a lua_State*) would die before everything referencing it would be properly dead. This made holding a reference for keep-alive purposes impossible to maintain. Therefore, we retrieve the main thread to keep it alive.
— 🔎 Silence uninitialized warning for later inspection
|
We have confirmed this fix works for the folks we were working with, and it additionally restores the tests to a working state (it does not expand the testing matrix in CI). OK to merge? |
ThePhD
added
Thank.You
Bug.Derp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request formally verifies that #1315 is fixed by adding it to the tests. It tests all the various permutation of collection-returns through Lua. Lua 5.2 specifically has the
ipairsmethod that calls the custom__ipairsmetamethod in Lua, and that is where the failure is detected as it did not keep the original collection (in the bug report's case, astd::vector). This failure does not seem to be present on Lua 5.1, 5.3 and 5.4 because the custom__ipairsmetamethod was deprecated and removed immediately after its introduction in 5.2.There is also some general fixes to update the behavior of some of the other tests and bring them in line with others, utilizing Catch2 to do so, which generally makes this a fairly messy commit. More commits will be added as this fix is verified for the users.